-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvement to the ai module #276
base: master
Are you sure you want to change the base?
Conversation
Hi, thanks for working on that. I think the general approach is fine, this PR doesn't function yet though. Small nitpicks:
As for not working: console spits out |
@abenz1267 thanks. I've addressed your comments. |
Modules/Plugins have a This could be simply changed in the default config. |
@abenz1267 lovely, that works great. I've updated the default on the ai module |
gemini := providers.NewGeminiProvider(ai.config, ai.SpecialFunc) | ||
if gemini != nil { | ||
ai.provider["gemini"] = gemini | ||
} | ||
anthropic := providers.NewAnthropicProvider(ai.config, ai.SpecialFunc) | ||
if anthropic != nil { | ||
ai.provider["anthropic"] = anthropic | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks rather repetitive to me. It should probably be handled in somekinda loop.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also: do you really need the "New*Provider" functions? To me it looks like everything should be handled in the providers SetupData
method, since you have a loop calling that already anyways. in ai.SetupData
.
Hi @abenz1267
I've 'generalized' the ai module and created another provider - Gemini.
What do you think of this approach?