Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace "-sh", "-c" with "env", "-S" #275

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

n-connect
Copy link

Trying to get a rid of the sh -c wrappers within hyprland session:

  • testing a patched hyprland since 0.47.2 -> works #9403
  • nwg-drawer, nwg-menu already got rid of the sh -c wrappings
  • now doing the same env -S "trick" with walker as my favorite app runner (and more).

As a first step - only the interactions.go file modified and tested - I'm using daily always.. I'll need to check and test the others: events, plugins, ai, clipboard, theme, ui.

Running programs, wayland or xwayland works (Through hyprland-polkit-agent, which adds its own /bin/sh wrap, :) )

Trying to get a rid of the `sh -c` wrappers within hyprland session:
- testing a patched hyprland since 0.47.2 -> work
- nwg-drawer, nwg-menu already got rid of
- now did the same `env -S` "trick" with walker as my favorite app runner (and more).

As a first only the interactions.go file modified and tested - in use. I'll need to check events, plugins, ai, clipboard, theme, ui first then test them separately.

Running programs, wayland or xwayland works (Through hyprland-polkit-agent, which adds its own `/bin/sh` wrap, :) )
@abenz1267
Copy link
Owner

Hello,

thank you for your contribution. I'm wondering:

would it be better to let this be defined via cfg?

@n-connect
Copy link
Author

@abenz1267

would it be better to let this be defined via cfg?

Thanks, for your quick answer. And thanks for walker itself, really nice!

Of course cfg definition would give a certain flexibility. It would be good to know, why they are there in the first place? So maybe there's no big need there at the first place.
Is it fulfills some deliberate function? Or "just" preserving and passing through the existing environment for starting a new binary/process/GUI app?
If the former, it should be cfg defined. If the latter, I think its just makes walker more "tidy". And stop adding to the look "this linux desktop it got hacked" :)

@abenz1267
Copy link
Owner

Pretty sure I just added it for preserving existing env-vars etc when launching things.

@n-connect
Copy link
Author

Great, would you test it yourself at this stage? The fact it is working for me just one positive sign.

Also I need to learn walker, as I literally use it for launching stuff, calc stuff checking currency rates and initiate google(web) search. Just like in macOS's Spotlight I'm working with. Aaand now I just saw it no longer shows in hint the currency value, but websearch only. :)

@abenz1267
Copy link
Owner

Could you replace every sh -c call? I'd then merge and push a release as soon as the other PR is done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants