Skip to content

Conversation

@Moyikc
Copy link

@Moyikc Moyikc commented Mar 17, 2025

Since #189 has not received a response, I tried to ask AI to modify some codes of live.mehiz.mpvkt.ui.player.controls to realize the display of multiple custom buttons in the navigation menu. The general plan is as follows:

  1. Remove the part related to displaying primaryCustomButton in BottomRightPlayerControls
  2. Create a new BottomCenterPlayerControls to create a slidable horizontal area in the middle of the bottom of the navigation menu to display custom buttons
  3. Adjust other control bars to coordinate with it.

After the modification, the compilation test passed, and the function is basically available, but there are still some problems to be solved:

  1. The primaryCustomButton function loses its meaning
  2. In the settings, there could be options to switch the display of custom buttons in the navigation menu and more menus, as well as options for controlling how many buttons are displayed.

@Secozzi
Copy link
Contributor

Secozzi commented Mar 17, 2025

This breaks some existing lua functions, namely set_button_title and reset_button_title

@Secozzi
Copy link
Contributor

Secozzi commented Mar 17, 2025

It's redundant to have all the buttons in both the player and in the more sheet. You should also do something about the toggle favorite buttons in settings, since they don't do anything now.

@Moyikc
Copy link
Author

Moyikc commented Mar 18, 2025

It's redundant to have all the buttons in both the player and in the more sheet. You should also do something about the toggle favorite buttons in settings, since they don't do anything now.

Actually, I thought so at first, but when I modified it, I found it was more complicated. I don't know much about programming, so I let AI modify the current codes. Later, as I said in problem 2, I will try to add setting options for each button whether it is shown in the player and more tables, but it will probably take a long time.

@Moyikc
Copy link
Author

Moyikc commented Mar 18, 2025

This breaks some existing lua functions, namely set_button_title and reset_button_title

Indeed, but I think "adding setting options for each button whether it is shown in the player and more tables" is a better feature than "primary custom button". Besides, I can't think of a suitable application scenario for this "set title" feature.

@Moyikc Moyikc reopened this Mar 19, 2025
@Moyikc
Copy link
Author

Moyikc commented Mar 19, 2025

I've added setting options for each button whether it is shown in the player and more sheets.

@Sheikh9822
Copy link

if you don't mind can u give me the apk file for arm64

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants