Skip to content

Fix SMPL humanoid qpos convention#147

Merged
abcamiletto merged 1 commit into
mainfrom
codex/fix-smpl-humanoid-qpos-convention
Jun 30, 2026
Merged

Fix SMPL humanoid qpos convention#147
abcamiletto merged 1 commit into
mainfrom
codex/fix-smpl-humanoid-qpos-convention

Conversation

@abcamiletto

@abcamiletto abcamiletto commented Jun 30, 2026

Copy link
Copy Markdown
Owner

Summary

  • convert SMPL humanoid axis-angle body pose to lowercase xyz Euler hinge coordinates for XML qpos
  • parse SMPL humanoid XML hinge ranges and use them for qpos clipping

Notes

  • No new tests added; existing expectations were updated for the XML qpos convention.
  • SmplHumanoid uses the identity MuJoCo/model root frame, so the generic RigidBodyModel.to_qpos root conversion is not the source of the mismatch here.

Verification

  • uv run ruff check src/body_models/robots/smpl_humanoid tests/test_smpl_humanoid.py tests/test_backend_consistency.py
  • uv run ruff format --check src/body_models/robots/smpl_humanoid tests/test_smpl_humanoid.py tests/test_backend_consistency.py
  • uv run --group dev --extra torch --extra jax ty check
  • uv run --group dev --extra torch --extra jax -m pytest tests/test_backend_consistency.py tests/test_smpl_humanoid.py -q
  • repro-style local comparison: mean abs qpos diff 2.45e-11, max abs qpos diff 3.73e-09

@abcamiletto abcamiletto force-pushed the codex/fix-smpl-humanoid-qpos-convention branch from 91a299c to 18acf29 Compare June 30, 2026 08:55
@abcamiletto abcamiletto merged commit cece840 into main Jun 30, 2026
3 checks passed
@abcamiletto abcamiletto deleted the codex/fix-smpl-humanoid-qpos-convention branch June 30, 2026 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant