moved source buffer struct member to local var in converter callback … #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -6,7 +6,7 @@ | |||
| #endif | |||
|
|
|||
|
|
|||
| #define kInputFileLocation CFSTR("/Insert/Path/To/Audio/File.xxx") | |||
| #define kInputFileLocation CFSTR("/Users/alexanderbollbach/Desktop/qt.m4a") | |||
There was a problem hiding this comment.
Should revert this back to the generic path /Insert/Path/To/Audio/File.xxx, since other users won't have an alexanderbollbach directory, and it's better for them to blow up on a self-explanatory problem if they forget to reset the kInputFileLocation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have been reading the Core Audio book and referencing these public repositories. I noticed certain TODO's and took that as an opportunity to practice my git skills and open source etiquette. There are undoubtedly some problems with this commit and pull request but I would appreciate some recommended revisions and I would work on getting my push in order to be pulled. I realize this is a rather trivial contribution but simply a chance to practice working within github's ecosystem.