Skip to content

fix(MessageSnapshots): Handle undefined messageRef channel ID #1582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
conorwastakenwastaken wants to merge 3 commits into
base: dev
Choose a base branch
from
Open

fix(MessageSnapshots): Handle undefined messageRef channel ID #1582

conorwastakenwastaken wants to merge 3 commits into from

Conversation

@conorwastakenwastaken
Copy link
Contributor

@conorwastakenwastaken conorwastakenwastaken commented Dec 3, 2024

No description provided.

@conorwastakenwastaken conorwastakenwastaken changed the title fix(Message Snapshots): Handle undefined messageRef channel ID fix(MessageSnapshots): Handle undefined messageRef channel ID Dec 3, 2024
bsian03
bsian03 requested changes Dec 13, 2024
View reviewed changes
Copy link
Collaborator

@bsian03 bsian03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I traced this back. Each snapshot needs to have the resolved message_reference's channel to be sniped to each (in the current case, the) message_snapshots. Currently message_snapshots does not contain a channel, which is causing this. OR snipe channel_id to each message_snapshot

@bsian03 bsian03 added the bug label Dec 13, 2024
@rubyowo rubyowo mentioned this pull request Dec 30, 2024
Open
@CyberFlameGO
Copy link

CyberFlameGO commented Feb 2, 2025

Hey! Any updates on this? It'd be lovely to get a fix deployable

@bsian03
Copy link
Collaborator

bsian03 commented Sep 27, 2025

@conorwastakenwastaken hi, can you commit my requested change please? would like this merged asap (i'm assuming this is still relevant at least)

@bsian03 bsian03 linked an issue Oct 7, 2025 that may be closed by this pull request
Forwarded message leads to a chain of errors in Message.js #1607
Open
@CyberFlameGO
Copy link

CyberFlameGO commented Oct 19, 2025

@conorwastakenwastaken hi, can you commit my requested change please? would like this merged asap (i'm assuming this is still relevant at least)

If you've got branch editing permission from the PR you might be able to do it, or you could merge and add a commit after? It 100% is still relevant :)

@conorwastakenwastaken
Copy link
Contributor Author

conorwastakenwastaken commented Oct 19, 2025

@conorwastakenwastaken hi, can you commit my requested change please? would like this merged asap (i'm assuming this is still relevant at least)

If you've got branch editing permission from the PR you might be able to do it, or you could merge and add a commit after? It 100% is still relevant :)

The requested changes were already made, it's just waiting on someone to review & merge it 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bsian03 bsian03 bsian03 requested changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Forwarded message leads to a chain of errors in Message.js

3 participants

@conorwastakenwastaken @CyberFlameGO @bsian03