feat: syrupUSDG on Eth mainnet Adapter - #161
Conversation
| abi.encode( | ||
| IPriceCapAdapter.CapAdapterParams({ | ||
| aclManager: AaveV3Ethereum.ACL_MANAGER, | ||
| baseAggregatorAddress: ChainlinkEthereum.USDG__USD, |
There was a problem hiding this comment.
this follows LLR recommendation, but it seems that we are diverging from v3 and v4 practices, where we use capped USDG/USD feeds. thoughts?
There was a problem hiding this comment.
LLR also recommended to use CL USDC feed for the syrupUSDC onboarding on V3, so I think they mean this to be the practice for those assets.
But we could also discuss it with them and make both use the Capped USDG & USDC.
There was a problem hiding this comment.
syrup tokens above (USDC and USDT) use capped oracles for base aggr
| * @notice Price capped adapter to calculate price of (SyrupUSDG / USD) pair by using | ||
| * @notice Capped adapter for (USDG / USD) and (SyrupUSDG / USDG) ratio. | ||
| */ | ||
| contract SyrupUSDGPriceCapAdapter is PriceCapAdapterBase { |
There was a problem hiding this comment.
I don't like that we create a new adapter for each individual token, since all syrup pools use same interface, but I know this is the pattern in this repo so fine for me at the moment
There was a problem hiding this comment.
yes, and this is what called the verification issue on Etherscan. I think in the future we can merge all 3 under MaplePriceCapAdapter or SyrupPriceCapAdapter
3 participants
Gov post : https://governance.aave.com/t/direct-to-aip-onboard-syrupusdg-on-aave-v4-global-dollar-hub/25281/2
syrupUSDG Adapter : https://etherscan.io/address/0x5a6fcb0ebc018b6fd94fc5f5a9f0948d0d40f040#code