Add toggle for enabling invisible scrollview (#1) #59
Conversation
* Add toggle for enabling invisible scrollview * Fix compiler error
|
Thanks for opening this @attyran 👍🏽. Is the intention that you can disable scrolling on the entire carousel? i.e What is the use case for this? Once I know this, I can review this better. |
|
Hi @superpeteblaze, Yes, that is the intention. For my project, I have a selected state for the centered cell. Upon clicking on the cell, I would magnify it and hide the left and right cells next to it. In addition, I would disable scrolling. Clicking on the cell again would scale it back, reshow the left and right cells, and enable scrolling. Hope that helps. |
|
Great, thanks for getting back to me. In that case, I have a couple of suggested changes to the PR. |
| This method should ALWAYS be called from the ScalingCarousel delegate when you want to | ||
| disable the invisible scroller. | ||
| */ | ||
| public func toggleInvisibleScrolling(_ toggle: Bool) { |
There was a problem hiding this comment.
Rather than a new function, we could add a didSet on the UIScrollView isScrollEnabled, and in it set the value of the invisible scrollviews isScrollEnabled.
There was a problem hiding this comment.
Great. I think it accomplishes two things:
- It makes the intent clearer
- It does not expose the invisible scroll view
There was a problem hiding this comment.
To confirm, did you wanted me to make these changes :)?
Hello,
I am using this library for a project, and needed a way to disable scrolling for the invisible scroll view. This doesn't seem to be available yet, so I forked the project and added functionality for it. Adding this PR in hope that it can go to the master branch eventually.