Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cookie_session: set path to / so router wildcards don't mess up sessions #387

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

cookie_session: set path to / so router wildcards don't mess up sessions #387

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/server/session.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
Copyright 2021 Anton Bachin *)



(* https://cheatsheetseries.owasp.org/cheatsheets/Session_Management_Cheat_Sheet.html *)

module Message = Dream_pure.Message
Expand Down Expand Up @@ -317,7 +316,7 @@ struct
|> Yojson.Basic.to_string
|> version_value
in
Cookie.set_cookie response request session_cookie value ~max_age
Cookie.set_cookie response request session_cookie value ~max_age ~path:(Some "/")
end;
Lwt.return response

Expand Down
Loading