-
Notifications
You must be signed in to change notification settings - Fork 230
Add a page to the website with a map showing the locations of the Java Champions #318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
FDelporte
wants to merge
29
commits into
aalmiray:main
Choose a base branch
from
FDelporte:feature/map
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 28 commits
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
bdd14db
Extra links
48a9561
Merge branch 'aalmiray:main' into main
FDelporte 4cd27de
Merge branch 'aalmiray:main' into main
FDelporte 8216d2f
Adding podcasts page to the website
FDelporte 82d2e43
Adding podcasts page to the website
FDelporte bd6ba7a
Adding podcasts page to the website
FDelporte 83a4f12
Adding podcasts page to the website
FDelporte a4025f4
Handle merge request remarks
FDelporte 05f39da
Merge branch 'aalmiray:main' into main
FDelporte e29b987
Update Bluesky for frankdelporte.be
FDelporte e2ec906
Update Bluesky for frankdelporte.be
FDelporte ce54e52
Merge branch 'main' into main
FDelporte 3fecf1d
Merge remote-tracking branch 'origin/main'
FDelporte caf363d
Add a map page, gets lat/long from opencagedata.com
FDelporte f2ee684
Add a map page, gets lat/long from opencagedata.com
FDelporte 6cdb186
Switch to geocode.maps.co
FDelporte 949d1dc
Cleanup
FDelporte 1bb41e9
Cleanup
FDelporte a7c14fa
Better parsing
FDelporte 91a45f1
Cleanup
FDelporte d02334f
Cleanup
FDelporte 550f341
Merge remote-tracking branch 'origin/main' into feature/map
9d1b676
Fixing merge conflicts
d10d9c3
Correct JBang command in CONTRIBUTING
dfc122e
Add link to repository
a30e257
Tested and working world map with almost all champions. A file gets g…
531bdfb
Added members map to menu
d0dbc36
Fix location error
19e2a7f
Fix unmatched locations
FDelporte File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,44 @@ | ||
| = Map | ||
| Frank Delporte | ||
| :jbake-type: page | ||
| :jbake-status: published | ||
| :linkattrs: | ||
|
|
||
| ++++ | ||
| <link rel="stylesheet" href="https://unpkg.com/[email protected]/dist/leaflet.css" /> | ||
| <link rel="stylesheet" href="https://unpkg.com/[email protected]/dist/MarkerCluster.css" /> | ||
| <link rel="stylesheet" href="https://unpkg.com/[email protected]/dist/MarkerCluster.Default.css" /> | ||
|
|
||
| <script src="https://unpkg.com/[email protected]/dist/leaflet.js"></script> | ||
| <script src="https://unpkg.com/[email protected]/dist/leaflet.markercluster.js"></script> | ||
|
|
||
| <div id="map" style="height: 800px;"></div> | ||
|
|
||
| <script> | ||
| var data = [@LOCATIONS@]; | ||
|
|
||
| document.addEventListener('DOMContentLoaded', function() { | ||
| var map = L.map('map').setView([0, 0], 2); | ||
|
|
||
| // Add a tile layer (OpenStreetMap) | ||
| L.tileLayer('https://{s}.tile.openstreetmap.org/{z}/{x}/{y}.png', { | ||
| attribution: '© OpenStreetMap contributors' | ||
| }).addTo(map); | ||
|
|
||
| var markers = L.markerClusterGroup({ | ||
| maxClusterRadius: 50, // Pixels to cluster markers | ||
| disableClusteringAtZoom: 10, // Don't cluster when zoomed in past this level | ||
| spiderfyOnMaxZoom: false // Spread out markers instead of zooming | ||
| }); | ||
| data.forEach(champion => { | ||
| var marker = L.marker([champion.lat, champion.lng], { | ||
| title: champion.name, | ||
| alt: champion.name | ||
| }); | ||
| marker.bindPopup(champion.name); | ||
| markers.addLayer(marker); | ||
| }); | ||
| map.addLayer(markers); | ||
| }); | ||
| </script> | ||
| ++++ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these 2 imports needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
org.json is used to parse the result from geo-api