Catch if some one has done something silly like passing in a string#601
Open
leighs-hammer wants to merge 1 commit intoaFarkas:masterfrom
Open
Catch if some one has done something silly like passing in a string#601leighs-hammer wants to merge 1 commit intoaFarkas:masterfrom
leighs-hammer wants to merge 1 commit intoaFarkas:masterfrom
Conversation
As this is in use on multiple shopify themes, I noticed a few failures where by some one has referenced widths from a data attribute without parsing it. I haven't dived in deep to see the source of the issues, I will, however just thought a sanity check here or further up where the default config is referencing it may be a good idea :)
Owner
|
@leighs-hammer |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As this is in use on multiple shopify themes, I noticed a few failures where by some one has referenced widths from a data attribute without parsing it. I haven't dived in deep to see the source of the issues, I will, however just thought a sanity check here or further up where the default config is referencing it may be a good idea :)