Fix: overwriting existing subtitles during auto-download #104
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes I noticed that even If I have the subtitle already exists a4ks may auto-download new subtitle and overwrite the existed one, and the downloaded subtitle aren't always correct if the episode doesn't exists in the website.
What causes the issue is that service try to access
player_props['currentsubtitle']['index']however for some-reasoncurrentsubtitleare not always defined which rise an error and skip the subtitle check process.Error line
a4kSubtitles/a4kSubtitles/service.py
Lines 235 to 237 in 42c41d3
Example logs: "the current language index is 0"
Now the change will instead of directly check
currentsubtitle -> index; Ifcurrentsubtitlevalue isn't defined it will set the preferred language.edit:
Not sure if
v3.22.0triggered because crc hasn't changed nor addon.xml updated.