Skip to content

Conversation

a2a-bot
Copy link
Collaborator

@a2a-bot a2a-bot commented Oct 16, 2025

Commit: a2aproject/A2A@0a9f629

Fixes #515 🦕

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @a2a-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the A2A API by introducing a new ListTasks method. This method provides a robust way to query and manage tasks, offering capabilities such as filtering by context ID and task status, specifying history length, filtering by last updated time, and controlling the inclusion of artifacts. It also supports pagination, making it suitable for handling large numbers of tasks efficiently. The changes span across the gRPC definitions and the Python type definitions, ensuring full integration and usability of this new feature.

Highlights

  • New ListTasks API Method: Introduced a new RPC method ListTasks to allow clients to retrieve a paginated and filterable list of tasks.
  • Expanded Task Management Capabilities: Added comprehensive request and response models for ListTasks, including parameters for filtering by context_id, status, history_length, last_updated_time, and options for pagination (page_size, page_token) and artifact inclusion.
  • Protocol Buffer Updates: Updated the Python generated protobuf files (a2a_pb2.py, a2a_pb2.pyi, a2a_pb2_grpc.py) to reflect the new ListTasks method and its associated message types, ensuring gRPC compatibility.
  • JSON-RPC Type Definitions: Integrated the new ListTasks functionality into the a2a/types.py file with new Pydantic models for JSON-RPC requests and responses, enhancing the Python client's ability to interact with this new API.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the A2A specification and the corresponding generated Python files to introduce the ListTasks functionality. The changes correctly add the necessary protobuf messages, gRPC service definitions, and Pydantic models for the JSON-RPC transport. It appears the implementation of these new endpoints in the server handlers and client transports is planned for future work.

My review focuses on the manually edited src/a2a/types.py file. I've suggested adding Pydantic validators to the ListTasksParams model to enforce constraints mentioned in the docstrings, which will improve data integrity. I also pointed out a small inconsistency in a docstring for better clarity. Overall, the changes are well-structured and align with the existing design.

@holtskinner holtskinner changed the title Update to specification from 0a9f629e801d4ae89f94991fc28afe9429c91cbc feat(spec): Add tasks/list method with filtering and pagination to the specification Oct 17, 2025
@lkawka lkawka self-assigned this Oct 20, 2025
@lkawka lkawka force-pushed the auto-update-a2a-types-0a9f629e801d4ae89f94991fc28afe9429c91cbc branch from 39b57dc to e5853a6 Compare October 21, 2025 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Task]: Implement tasks/list method

2 participants