-
Notifications
You must be signed in to change notification settings - Fork 260
ci: Script for checking-out experimental types #507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @lkawka, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a new shell script designed to streamline the development process for features based on unmerged A2A specification changes. By automating the generation of Python types from a specified A2A spec branch, it enables developers to create dedicated feature branches with the necessary updated types, facilitating early integration and testing of experimental functionalities. This enhancement significantly reduces manual setup time and ensures consistency when working with evolving specifications. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a helpful script for generating Python types from experimental A2A spec changes. The script is well-structured with argument parsing and a usage function. My review focuses on improving the script's robustness and safety, particularly concerning file system operations like temporary directory handling and path calculations. I've also suggested changes to make the script less dependent on specific repository naming conventions, which will enhance its reliability and maintainability.
Note: I changed the conventionalcommits.org type to be |
/gemini review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a helpful script for generating experimental types from the specification repository, which will streamline development against unmerged changes. The modifications to generate_types.sh
enhance its flexibility by allowing local file inputs. The new checkout_experimental_types.sh
script is well-structured, but I've identified a few areas for improvement regarding robustness, clarity, and the removal of non-functional code. My suggestions aim to make the scripts more reliable and easier to maintain.
Description
Added a script for creating a new feature branch with types generated from unmerged A2A spec changes.
We need to begin development on several upcoming spec changes that are currently unmerged but are highly likely to be included in the next release, such as the task/list method. To do that, we need updated types, which this script provides.
Prerequisites
CONTRIBUTING
Guide.fix:
which represents bug fixes, and correlates to a SemVer patch.feat:
represents a new feature, and correlates to a SemVer minor.feat!:
, orfix!:
,refactor!:
, etc., which represent a breaking change (indicated by the!
) and will result in a SemVer major.bash scripts/format.sh
from the repository root to format)