Skip to content

Conversation

lkawka
Copy link
Member

@lkawka lkawka commented Oct 15, 2025

Description

Added a script for creating a new feature branch with types generated from unmerged A2A spec changes.

We need to begin development on several upcoming spec changes that are currently unmerged but are highly likely to be included in the next release, such as the task/list method. To do that, we need updated types, which this script provides.

Prerequisites

  • Follow the CONTRIBUTING Guide.
  • Make your Pull Request title in the https://www.conventionalcommits.org/ specification.
    • Important Prefixes for release-please:
      • fix: which represents bug fixes, and correlates to a SemVer patch.
      • feat: represents a new feature, and correlates to a SemVer minor.
      • feat!:, or fix!:, refactor!:, etc., which represent a breaking change (indicated by the !) and will result in a SemVer major.
  • Ensure the tests and linter pass (Run bash scripts/format.sh from the repository root to format)
  • Appropriate docs were updated (if necessary)

@lkawka lkawka requested a review from a team as a code owner October 15, 2025 12:40
Copy link
Contributor

Summary of Changes

Hello @lkawka, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new shell script designed to streamline the development process for features based on unmerged A2A specification changes. By automating the generation of Python types from a specified A2A spec branch, it enables developers to create dedicated feature branches with the necessary updated types, facilitating early integration and testing of experimental functionalities. This enhancement significantly reduces manual setup time and ensures consistency when working with evolving specifications.

Highlights

  • New Script for Experimental Types: A new shell script, checkout_experimental_types.sh, has been added to automate the generation of Python types from unmerged A2A specification changes. This allows developers to work with upcoming spec features before they are officially integrated into the main branch.
  • Automated Type Generation: The script clones the A2A spec repository, checks out a specified branch, and uses datamodel-codegen to generate pydantic_v2.BaseModel types from the A2A JSON schema. It then formats the generated file using ruff.
  • Feature Branch Creation: After generating and formatting the types, the script automatically creates a new Git feature branch, commits the newly generated types, and cleans up temporary files, streamlining the setup for experimental development.
  • Configurable Options: The script is highly configurable, allowing users to specify the A2A spec repository URL, the experimental spec branch name, the desired feature branch name, and the temporary working directory via command-line arguments.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a helpful script for generating Python types from experimental A2A spec changes. The script is well-structured with argument parsing and a usage function. My review focuses on improving the script's robustness and safety, particularly concerning file system operations like temporary directory handling and path calculations. I've also suggested changes to make the script less dependent on specific repository naming conventions, which will enhance its reliability and maintainability.

@holtskinner holtskinner changed the title feat: Script for checking-out experimental types ci: Script for checking-out experimental types Oct 15, 2025
@holtskinner
Copy link
Member

Note: I changed the conventionalcommits.org type to be ci: instead of feat: this isn't actually a feature for the SDK, it's for internal development.

@holtskinner
Copy link
Member

/gemini review

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a helpful script for generating experimental types from the specification repository, which will streamline development against unmerged changes. The modifications to generate_types.sh enhance its flexibility by allowing local file inputs. The new checkout_experimental_types.sh script is well-structured, but I've identified a few areas for improvement regarding robustness, clarity, and the removal of non-functional code. My suggestions aim to make the scripts more reliable and easier to maintain.

@lkawka lkawka merged commit 9c21e1a into a2aproject:main Oct 22, 2025
6 checks passed
@lkawka lkawka deleted the experimental-types-script branch October 22, 2025 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants