-
Notifications
You must be signed in to change notification settings - Fork 269
feat(client): allow specifying historyLength via call-site MessageSendConfiguration in BaseClient.send_message #500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…behavior in BaseClient.send_message
Summary of ChangesHello @TadakiAsechi, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a valuable enhancement by allowing per-call configuration overrides in BaseClient.send_message. The implementation is straightforward and correctly merges the call-site configuration with the client's defaults. The addition of unit tests for both streaming and non-streaming scenarios ensures the new functionality is well-covered. I have a few minor suggestions to improve the readability of the new tests.
|
/gemini review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces the ability to specify historyLength and other message configuration options directly via the configuration parameter in BaseClient.send_message. This enhancement aligns client behavior across methods and fixes issue #499. The changes include adding an optional argument to send_message, merging call-site configuration with defaults, updating docstrings, and adding unit tests. No style guide was provided, so the review focuses on correctness, efficiency, maintainability, and security.
…nfiguration tests
Description
This PR implements the client-side enhancement described in #499.
It allows callers to specify
historyLength(and other message configuration options)directly via the optional configuration parameter in
BaseClient.send_message,complementing the server-side support added in #497.
Summary of Changes
configuration: MessageSendConfiguration | NonetoBaseClient.send_message.ClientConfigdefaults.historyLengthonly).Motivation
Previously,
BaseClient.send_messagebuiltMessageSendConfigurationinternally fromClientConfig,but
ClientConfigdoes not includehistory_length.This prevented clients from specifying it on a per-call basis, unlike
get_task,which already supports
historyLengthviaTaskQueryParams.After this change, client behavior becomes consistent across both methods.
Related Issues
Fixes #499
Complements #497 (server-side historyLength support)