Skip to content

Conversation

@ehsavoie
Copy link
Collaborator

  • Added a method field to ServerCallContext.state, similar to headers.

Issue: #352

Fixes #352 🦕

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @ehsavoie, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the ServerCallContext by integrating the method name into its state for both JSON-RPC and REST requests. This change provides a more comprehensive context for service handlers, allowing them to access the specific operation being performed. Additionally, it introduces dedicated constant classes for context keys and standardizes the use of content type constants, contributing to a more robust and maintainable codebase.

Highlights

  • Method Name in ServerCallContext: The JSON-RPC method name is now added to the ServerCallContext.state for both streaming and non-streaming requests, providing handlers with direct access to the invoked method.
  • REST Method Name Explicitly Set: For REST endpoints, the createCallContext method now explicitly accepts and stores the REST method name in the ServerCallContext.state, ensuring consistent context availability across different request types.
  • Standardized Context Keys: New utility classes, JSONRPCContextKeys and RestContextKeys, have been introduced to define standardized keys for HEADERS_KEY and METHOD_NAME_KEY within the ServerCallContext, improving maintainability and reducing magic strings.
  • Content Type Constant Usage: Hardcoded content type strings like "content-type" and "text/event-stream" have been replaced with their respective constants (CONTENT_TYPE and SERVER_SENT_EVENTS) for improved consistency and type safety.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds the JSON-RPC method name to the ServerCallContext.state, which is a useful addition for context-aware processing. The implementation introduces new constant classes for context keys and updates both JSON-RPC and REST route handlers to populate the state. The changes also commendably replace several magic strings with constants, improving code maintainability. My review includes a suggestion to refactor a block of code in the JSON-RPC handler to improve efficiency and reduce duplication, and a minor formatting fix in the REST handler.

* Added a `method` field to `ServerCallContext.state`, similar to
`headers`.
* Adding unit tests to cover that.

Issue: a2aproject#352

Signed-off-by: Emmanuel Hugonnet <[email protected]>
@fjuma fjuma requested a review from kabir October 22, 2025 16:19
@kabir kabir merged commit ba7f9fe into a2aproject:main Oct 22, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feat]: add JSON-RPC method to ServerCallContext.state

3 participants