Fixup install.sh output. #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also improve docker dev-cmd to support `--inspect` and cache image builds.
jsirois
commented
Feb 18, 2025
| @@ -107,9 +107,9 @@ fetch() { | |||
| curl --proto '=https' --tlsv1.2 -SfL --progress-bar -o "${dest}" "${url}" | |||
| } | |||
|
|
|||
| ensure_cmd $([ "${OS}" == "macos" ] && echo "shasum" || echo "sha256sum") | |||
| ensure_cmd $([ "${OS}" = "macos" ] && echo "shasum" || echo "sha256sum") | |||
There was a problem hiding this comment.
Beyond the colored logging not working - fixes above - there were a few warnings / errors from [[ and == bashisms missed in the 1st round.
|
@kwlzn FYI. I'm going to merge this presently to fix |
jsirois
added a commit
that referenced
this pull request
Feb 18, 2025
A follow-up to #142 which left debian and alpine amd64 images colliding.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also improve docker dev-cmd to support
--inspectand cache imagebuilds.
A follow-up to #141 which left install.sh working, but with ugly
output that rendered escape codes instead of colors.