[Bug]: pal card falls back to creator avatar when no thumbnail - #746
Merged
Conversation
Pal cards with no thumbnail were falling back to the creator's avatar, which for self-authored pals shows the user's own profile picture. Fall through to the first-letter placeholder, matching PalDetailSheet.
There was a problem hiding this comment.
Pull request overview
Fixes a UI bug in the Pals list where SquarePalCard would render a pal’s creator avatar as the thumbnail when the pal had no thumbnail_url, causing self-authored pals to appear “branded” with the user’s profile picture. The card now falls back directly to the neutral first-letter placeholder (consistent with PalDetailSheet behavior referenced in the PR description).
Changes:
- Remove the creator-avatar fallback branch in
SquarePalCardthumbnail rendering. - Simplify the thumbnail JSX to render either the pal thumbnail image or the first-letter placeholder.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SquarePalCard) without athumbnail_urlwere falling back to the creator'savatar_url. For pals you authored yourself (locally or via PalsHub), the creator avatar is your own profile picture — so blank-thumbnail pals looked like they were branded with your face.PalDetailSheet(neutral placeholder, never the creator avatar).Test plan
yarn test src/screens/PalsScreen/components/SquarePalCard— 28/28 passyarn tsc --noEmit— cleanyarn lint src/screens/PalsScreen/components/SquarePalCard/SquarePalCard.tsx— 0 errorsGenerated by PocketPal Dev Team