Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/pals #205

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Feat/pals #205

wants to merge 10 commits into from

Conversation

Mukhammadali
Copy link
Collaborator

@Mukhammadali Mukhammadali commented Feb 10, 2025

Description

Changes:

  • Introduced PalsScreen with support for creating and managing AI assistants and roleplay characters
  • Added new components for Pals creation: AssistantPalSheet, RoleplayPalSheet, ModelSelector, FormField
  • Implemented PalStore for managing Pals data with persistence
  • Added new icons and updated existing components to support Pals functionality
  • Integrated Pals into navigation and sidebar
  • Updated theme and styling to support new Pals-related UI elements

Fixes #150

Platform Affected

  • iOS
  • Android

Checklist

  • Necessary comments have been made.
  • I have tested this change on:
    • iOS Simulator/Device
    • Android Emulator/Device
  • Unit tests and integration tests pass locally.

@a-ghorbani
Copy link
Owner

a-ghorbani commented Feb 11, 2025

  • Test fails due to: Jest: "global" coverage threshold for branches (60%) not met: 57.3%
  • We need to add 'delete' functionality for Pals.
  • [Bug] Edit pals – previous values do not persist when navigating away and returning to the Pals screen.
  • Roleplay prompt generator doesn't use models stop words
  • Add chevron to model selectors
  • Add text to the model selector indicating which models are best for prompt generation.
  • When there are many palls or downloaded models the sheet doesn't scroll up enough.
  • Add stop for ai prompt generator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feat]: Character Sheet Support
2 participants