-
-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/chat UI improvements #201
Conversation
* feat: update menu component * chore: add translations * feat: show available models inside chat menu * fix: unit tests
* feat: added chat generation settings, rename, remove, duplicate functionalities into chat menu * feat: add rename functionality into chat menu, update tests, and refactor code * chore: updated translations * chore: fix lint issues
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
export * from './ChatGenerationSettingsSheet';
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
then in src/component/index.ts
we need to add
export * from './ChatGenerationSettingsSheet';
after (export * from './Bubble';
)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and header right can import like:
import {ChatGenerationSettingsSheet} from '..';
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alternatively, if we use a different visual cue (highlight, bold, etc) to show which model is selected, we can remove the leading space reserved for the icon in the model list. This would free up enough space as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Description
Provide a brief description of the changes made and the issue(s) this resolves.
Changes:
Platform Affected
Checklist