Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/chat UI improvements #201

Merged
merged 5 commits into from
Feb 5, 2025
Merged

Feat/chat UI improvements #201

merged 5 commits into from
Feb 5, 2025

Conversation

Mukhammadali
Copy link
Collaborator

Description

Provide a brief description of the changes made and the issue(s) this resolves.

Changes:

  • Updated Menu component styles
  • Added new Chat Menu with chat generation settings, model selection, rename, delete, duplicate functionalities
  • Updated Model settings UI
  • Updated Chat Header which now displays active model

Platform Affected

  • iOS
  • Android

Checklist

  • Necessary comments have been made.
  • I have tested this change on:
    • iOS Simulator/Device
    • Android Emulator/Device
  • Unit tests and integration tests pass locally.

* feat: update menu component

* chore: add translations

* feat: show available models inside chat menu

* fix: unit tests
* feat: added chat generation settings, rename, remove, duplicate functionalities into chat menu

* feat: add rename functionality into chat menu, update tests, and refactor code

* chore: updated translations

* chore: fix lint issues
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

export * from './ChatGenerationSettingsSheet';

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

then in src/component/index.ts we need to add
export * from './ChatGenerationSettingsSheet'; after (export * from './Bubble';)

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and header right can import like:
import {ChatGenerationSettingsSheet} from '..';

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the submenu width is restricted by its parent menu? Is there an easy way to allow the submenu to be wider than the parent? The model names need more space, and we have extra space available to display them. It is a minor issue, it we don't have an easy fix, let's skip for now.

Screenshot 2025-02-05 at 07 55 36

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alternatively, if we use a different visual cue (highlight, bold, etc) to show which model is selected, we can remove the leading space reserved for the icon in the model list. This would free up enough space as well.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done
image

@a-ghorbani a-ghorbani merged commit bf3e88b into main Feb 5, 2025
2 of 3 checks passed
@a-ghorbani a-ghorbani deleted the feat/chat-ui-improvements branch February 5, 2025 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants