Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add text selection functionality in chat view with modal support #195

Draft
wants to merge 26 commits into
base: main
Choose a base branch
from

Conversation

MSBaigO
Copy link
Contributor

@MSBaigO MSBaigO commented Jan 31, 2025

Description

Added text selection functionality in chat view with a new modal for viewing the chat message and selecting only a portion of the text.

SelectText_Final.webm

Fixes # (issue number)

Platform Affected

  • iOS
  • Android

Checklist

  • I have tested this change on:
    • Android Emulator/Device

@MSBaigO MSBaigO marked this pull request as ready for review January 31, 2025 04:05
sohailbaig added 25 commits January 30, 2025 22:20
@a-ghorbani
Copy link
Owner

Thanks for this PR! This is a great feature to have.

Not sure if you're suggesting it's ready to merge, or still working on this, but I noticed a few issues, if it helps:

  • Android: Selection and scrolling often conflict (for long texts). ie when I intend to scroll, often it starts selecting.
  • iOS: See the screenshot below. The safe area isn't working at the top, and hold/select doesn't function properly.
  • Tests: There's a failing test.

Let me know how you'd like to proceed!

Simulator Screenshot - iPhone 15 Pro - 2025-02-04 at 07 49 02

@MSBaigO
Copy link
Contributor Author

MSBaigO commented Feb 5, 2025

Thanks for this PR! This is a great feature to have.

Not sure if you're suggesting it's ready to merge, or still working on this, but I noticed a few issues, if it helps:

  • Android: Selection and scrolling often conflict (for long texts). ie when I intend to scroll, often it starts selecting.
  • iOS: See the screenshot below. The safe area isn't working at the top, and hold/select doesn't function properly.
  • Tests: There's a failing test.

Let me know how you'd like to proceed!

Ok will look into fixing these issues. Currently I'm unable to test on IOS since I don't have the VM installed or a device. Also locally the tests seem to pass when testing with 'yarn test' not sure if I'm there's a different way to test.
image

@MSBaigO MSBaigO marked this pull request as draft February 5, 2025 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants