feat: update theme colors & fonts #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a-ghorbani
reviewed
Jan 28, 2025
react-native.config.js
Outdated
| android: {}, | ||
| }, | ||
| assets: ['./src/assets/fonts'], | ||
| }; |
a-ghorbani
reviewed
Jan 29, 2025
| @@ -587,8 +623,7 @@ | |||
| ); | |||
| PRODUCT_BUNDLE_IDENTIFIER = ai.pocketpal; | |||
| PRODUCT_NAME = PocketPal; | |||
| PROVISIONING_PROFILE_SPECIFIER = "match AppStore ai.pocketpal"; | |||
| "PROVISIONING_PROFILE_SPECIFIER[sdk=iphoneos*]" = "match AppStore ai.pocketpal"; | |||
There was a problem hiding this comment.
not sure! could these fail the fastlane ci for app store build/submission?
| @@ -560,11 +597,10 @@ | |||
| buildSettings = { | |||
| ASSETCATALOG_COMPILER_APPICON_NAME = AppIcon; | |||
| CLANG_ENABLE_MODULES = YES; | |||
| "CODE_SIGN_IDENTITY[sdk=iphoneos*]" = "Apple Distribution"; | |||
| CODE_SIGN_IDENTITY = "Apple Development"; | |||
There was a problem hiding this comment.
could these fail the fastlane ci for app store build/submission?
| CODE_SIGN_STYLE = Manual; | ||
| CURRENT_PROJECT_VERSION = 46; | ||
| DEVELOPMENT_TEAM = MYXGXY23Y6; | ||
| "DEVELOPMENT_TEAM[sdk=iphoneos*]" = MYXGXY23Y6; | ||
| "DEVELOPMENT_TEAM[sdk=iphoneos*]" = 8BAT9SJ33N; |
There was a problem hiding this comment.
same here: could these fail the fastlane ci for app store build/submission?
ios/Podfile.lock
Outdated
| SocketRocket: d4aabe649be1e368d1318fdf28a022d714d65748 | ||
| Yoga: 3deb2471faa9916c8a82dda2a22d3fba2620ad37 | ||
|
|
||
| PODFILE CHECKSUM: 3a849f0fd1fa4567c5aecd29d88c9ab4cc38b8d2 | ||
|
|
||
| COCOAPODS: 1.16.2 | ||
| COCOAPODS: 1.15.2 |
There was a problem hiding this comment.
we are changing cocopods version. is it needed?
There was a problem hiding this comment.
This file is auto generated, I think I have the older version installed. Will fix it
Mukhammadali
force-pushed
the
feat/update-theme-colors-font
branch
from
0ca4a3d to
4f114dd
Compare
|
@a-ghorbani Resolved the mentioned issues |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Provide a brief description of the changes made and the issue(s) this resolves.
Fixes # (issue number)
Platform Affected
Checklist