Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: update keyboard avoidance for android 15 and improve modal behavior #167

Merged
merged 13 commits into from
Jan 11, 2025

Conversation

a-ghorbani
Copy link
Owner

@a-ghorbani a-ghorbani commented Jan 11, 2025

Description

This PR resolves the keyboard avoidance issue on Android 15 (API 35).
The root cause was the outdated KeyboardAccessoryView.
It is replaced it with the more actively maintained package: react-native-keyboard-controller.

This PR also improves the keyboard avoiding behavior for modals, specifically on Android.
Still auto-scrolling remains an issue on iOS.

Warning messages have been added to the HF search model details card.

Fixes #134

Platform Affected

  • iOS
  • Android

Checklist

  • Necessary comments have been made.
  • I have tested this change on:
    • iOS Simulator/Device
    • Android Emulator/Device
  • Unit tests and integration tests pass locally.

@a-ghorbani a-ghorbani marked this pull request as ready for review January 11, 2025 21:31
@a-ghorbani a-ghorbani merged commit 818787c into main Jan 11, 2025
2 of 3 checks passed
@a-ghorbani a-ghorbani deleted the fix/android-15-keyboard-avoiding-chat-input branch January 11, 2025 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Text Input Hidden Below Keyboard on Android
1 participant