Skip to content

Fixed_ArchLinux_preview_not_working #2483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixed_ArchLinux_preview_not_working #2483

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions moviepy/video/io/ffmpeg_tools.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -328,5 +328,8 @@ def ffplay_version():
result = subprocess.run(cmd, capture_output=True, text=True, check=True)
# Extract the version number from the first line of output
full_version = result.stdout.splitlines()[0].split()[2]
#On Arch linux ffmpeg versions start with n, then the version number, this makes sure that no errors occur.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't comment on the code side of this, but would ask you clean up the comment. Spelling of proper names and punctuation should be fixed (missing whitespace after # for consistency with other comments; use full stop or semi-colon to split the sentence in two for readability).

if full_version.startswith("n"):
full_version = full_version[1:]
numeric_version = re.match(r"^[0-9.]+", full_version).group(0)
return (full_version, numeric_version)