Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZBUG-3131 Remove hard-coded password from createBulkAccounts #1666

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions store/src/java/com/zimbra/cs/account/ProvUtil.java
Original file line number Diff line number Diff line change
Expand Up @@ -546,8 +546,8 @@ public enum Command {
CREATE_ALWAYSONCLUSTER("createAlwaysOnCluster", "caoc",
"{name} [attr1 value1 [attr2 value2...]]", Category.ALWAYSONCLUSTER, 1, Integer.MAX_VALUE),
CREATE_BULK_ACCOUNTS(
"createBulkAccounts", "cabulk", "{domain} {namemask} {number of accounts to create}", Category.MISC, 3,
3),
"createBulkAccounts", "cabulk", "{domain} {namemask} {number of accounts to create} {password}", Category.MISC, 4,
4),
CREATE_CALENDAR_RESOURCE("createCalendarResource", "ccr",
"{name@domain} {password} [attr1 value1 [attr2 value2...]]", Category.CALENDAR, 2, Integer.MAX_VALUE),
CREATE_COS(
Expand Down Expand Up @@ -2159,11 +2159,11 @@ private void doResetAllLoggers(String[] args) throws ServiceException {
}

private void doCreateAccountsBulk(String[] args) throws ServiceException {
if (args.length < 3) {
if (args.length < 4) {
usage();
} else {
String domain = args[1];
String password = "test123";
String password = args[4];
String nameMask = args[2];
int numAccounts = Integer.parseInt(args[3]);
for (int ix = 0; ix < numAccounts; ix++) {
Expand Down