Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZCS-11691: Cannot send meeting with message attachment(.msg) using mo… #1362

Merged
merged 1 commit into from
Aug 17, 2022

Conversation

gabhinavTI
Copy link
Contributor

Issue: Cannot send meeting with message attachment(.msg) using modern UI(tika-parsers issue)

Whenever we attach a .msg file while sending an invite it would fail with an error
ua=ZimbraXWebClient - GC103 (Windows)/9.1.0_BETA_4334;soapId=7e9080de;] SoapEngine - handler exception java.lang.NoClassDefFoundError: org/apache/james/mime4j/codec/DecodeMonitor at org.apache.tika.parser.microsoft.OutlookExtractor.decodeHeader(OutlookExtractor.java:563) ~[tika-parsers-1.24.1.jar:1.24.1] at org.apache.tika.parser.microsoft.OutlookExtractor.normalizeHeaders(OutlookExtractor.java:529) ~[tika-parsers-1.24.1.jar:1.24.1] at org.apache.tika.parser.microsoft.OutlookExtractor.parse(OutlookExtractor.java:161) ~[tika-parsers-1.24.1.jar:1.24.1] at org.apache.tika.parser.microsoft.OfficeParser.parse(OfficeParser.java:199) ~[tika-parsers-1.24.1.jar:1.24.1] at org.apache.tika.parser.microsoft.OfficeParser.parse(OfficeParser.java:131) ~[tika-parsers-1.24.1.jar:1.24.1] at org.apache.tika.parser.CompositeParser.parse(CompositeParser.java:280) ~[tika-core-1.24.1.jar:1.24.1]

Basically upon checking DecodeMonitor class was missing. This class is available in org.apache.james. Adding this resolved the issue. Raised PR in zm-zcs-lib : Zimbra/zm-zcs-lib#101

Testing: Manual testing to send invites by adding .msg attachment and it's successfully sent

@silentsakky
Copy link
Member

if I understand correctly then tika parser is used to parse attachments and create indexes for search, why do we need to parse message in message attachments?

@gabhinavTI
Copy link
Contributor Author

if I understand correctly then tika parser is used to parse attachments and create indexes for search, why do we need to parse message in message attachments?

@silentsakky the attachments here is .msg file. Files with .msg attachment. Without this dependency, the parsing of this file attachment would fail hence we were getting error. As per current code logic, all the attachments get parsed

@gabhinavTI gabhinavTI merged commit 6f45559 into develop Aug 17, 2022
@gabhinavTI gabhinavTI deleted the bugfix/ZCS-11691 branch August 17, 2022 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants