ZBUG-1932: Upgrading owasp-java-html-sanitizer version #1227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rcyarrapothu
force-pushed
the
bugfix/ZBUG-1932
branch
from
f21e6b5 to
50f2604
Compare
rcyarrapothu
requested review from
desouzas,
ronstra-synacor,
log2akshat,
dasiyogesh and
silentsakky
rcyarrapothu
force-pushed
the
bugfix/ZBUG-1932
branch
2 times, most recently
from
e85490a to
1b386a3
Compare
log2akshat
approved these changes
Feb 9, 2022
dasiyogesh
reviewed
Feb 9, 2022
rcyarrapothu
force-pushed
the
bugfix/ZBUG-1932
branch
3 times, most recently
from
52157cf to
1c851e2
Compare
dasiyogesh
approved these changes
Feb 10, 2022
ronstra-synacor
approved these changes
Feb 10, 2022
rcyarrapothu
force-pushed
the
bugfix/ZBUG-1932
branch
from
1c851e2 to
d9c31f8
Compare
rcyarrapothu
force-pushed
the
bugfix/ZBUG-1932
branch
from
d9c31f8 to
1f95d28
Compare
desouzas
approved these changes
Feb 25, 2022
umagmrit
pushed a commit
that referenced
this pull request
Apr 10, 2022
dasiyogesh
pushed a commit
that referenced
this pull request
Apr 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
When OWASP zimbra_use_owasp_html_sanitizer = true, URL in the HTML message is getting modified. Character &num replace by #_
Issues: ZBUG-1932
Fix:
ZBUG-1932
Issue has been fixed in the original owasp library and zimbra java-html-sanitizer-release-20190610.1 is rebased with the latest release. These test cases are to make sure the urls are not changed as mentioned in the ticket when html is sanitized with newer jar.
Ref PRs:
java-html-sanitizer#6
zm-zcs-lib#89