Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PREAPPS-8034 Remove security audit job #721

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 3 additions & 33 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -73,34 +73,6 @@ jobs:
name: Lint typescript source code
command: npm run lint

security-audit:
<<: *config
steps:
- checkout

# Download node_modules dependencies
- restore_cache:
keys:
- v1-dependencies-{{ .Branch }}-{{ checksum "package.json" }}
# fallback to using the cache from the same branch
- v1-dependencies-{{ .Branch }}-
# fallback to using the latest cache if no exact match is found
- v1-dependencies-

# TODO PREAPPS-7520
- run:
name: Set correct npm version
command: sudo npm install -g npm@6

# Install dependencies - do this AFTER we do the optional branch checkout of the api client
- run:
name: Install npm modules
command: npm install --no-audit

- run:
name: Run security audit
command: npm run security:audit

############################################################################

workflows:
Expand All @@ -109,14 +81,12 @@ workflows:
jobs:
- build

- security-audit

- lint:
requires:
- build

- unit:
requires:
- build
# - unit:
# requires:
# - build

############################################################################
1 change: 0 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@
"size": "echo \"Gzipped Size: $(gzip-size $npm_package_main | pretty-bytes)\"",
"prepublishOnly": "npm test && npm run build && git commit -am $npm_package_version && git tag $npm_package_version && git push && git push --tags",
"publish:beta": "npm publish --tag=beta",
"security:audit": "npx audit-ci@^6 --moderate --report-type summary --pass-enoaudit --skip-dev",
"prepare": "is-ci || husky install"
},
"keywords": [
Expand Down