Handle SIGHUP to cause the log to rotate/get a new one manually #494
Conversation
|
This looks great thanks for the contribution! What are your thoughts on behavior if |
|
Good point. Perhaps we only support SIGHUP if rotate or increment is used? I'll implement that and add a print if SIGHUP is received and we're not in that configuration. |
…ome more context to the --rotate / --increment error message.
|
I've updated the PR with a check that ignores SIGHUP if the user hasn't specified |
tools/cpp/logger/main.cpp
Outdated
| @@ -683,6 +703,7 @@ int main(int argc, char *argv[]) | |||
| signal(SIGINT, sighandler); | |||
| signal(SIGQUIT, sighandler); | |||
| signal(SIGTERM, sighandler); | |||
| signal(SIGHUP, sighup_handler); | |||
There was a problem hiding this comment.
You can register this handler only in the cases you want to actually handle the signal. Specifically args.auto_increment || args.rotate > 0
|
All updated, note there is a slight behavior change in that if we don't register SIGHUP handler, the logger will quit when it receives a SIGHUP. |
|
Ahh good point. Let's preserve the old behavior with the registering the signal. But you can just not set the variable in the callback unless it's relevant to |
|
Addressed comments in #496 |
The zcm-logger help says that SIGHUP should cause the log to rotate, but that didn't work for me.
I have implemented that functionality here.