Skip to content

Commit

Permalink
Allow disabling of node dependency installation and fix cython subscr…
Browse files Browse the repository at this point in the history
…iption cleanup (#504)

* Allow disabling of node dependency installation

* Add python3-dev package (for python-config)

* Move python subscription cleanup to __del__
  • Loading branch information
jrgriffin94 authored Feb 1, 2025
1 parent 411a95a commit cdce21f
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
4 changes: 2 additions & 2 deletions scripts/install-deps.sh
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ USE_JULIA=true
JULIA_0_6_MODE=false
USE_NODE=true
USE_PYTHON_2=false
while getopts "ijmsp" opt; do
while getopts "ijmnsp" opt; do
case $opt in
i) STRICT=false ;;
j) USE_JULIA=false ;;
Expand Down Expand Up @@ -59,7 +59,7 @@ PKGS+='default-jdk default-jre '
if $USE_PYTHON_2; then
PKGS+='python python-pip '
else
PKGS+='python3 python3-pip '
PKGS+='python3 python3-dev python3-pip '
fi
PIP_PKGS+='Cython==0.29.33 '
PIP_PKGS+='bitstruct '
Expand Down
3 changes: 2 additions & 1 deletion zcm/python/zerocm.pyx
Original file line number Diff line number Diff line change
Expand Up @@ -108,10 +108,11 @@ cdef class ZCM:
def __dealloc__(self):
if self.zcm == NULL:
return
zcm_destroy(self.zcm)
def __del__(self):
self.stop()
while len(self.subscriptions) > 0:
self.unsubscribe(self.subscriptions[0]);
zcm_destroy(self.zcm)
def good(self):
return self.zcm != NULL
def strerrno(self, err):
Expand Down

0 comments on commit cdce21f

Please sign in to comment.