suggestion: Avoid new uses of lazy_static #5559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teor2345
added
A-dependencies
5 tasks
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## issue5452 #5559 +/- ##
=============================================
+ Coverage 78.82% 78.87% +0.05%
=============================================
Files 305 305
Lines 38126 38126
=============================================
+ Hits 30051 30073 +22
+ Misses 8075 8053 -22 |
|
@Mergifyio update |
✅ Branch has been successfully updated |
|
@Mergifyio update |
✅ Branch has been successfully updated |
oxarbitrage
approved these changes
Nov 7, 2022
There was a problem hiding this comment.
Thanks, i tried to do the const array as you do here but i was not able to remember how to do it. I didn't thought it was a big deal (we have lazy statics already).
Anyway, thanks for the fix. I also missed those documentations so thank you for adding them too.
mergify bot
added a commit
that referenced
this pull request
Nov 8, 2022
* add fixed values to getblocktemplate rpc call response * suggestion: Avoid new uses of lazy_static (#5559) * Avoid using lazy_static * Add some missing documentation Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> * minor fixes * move docs to struct * add fixed values to coinbase tx Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: teor <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This is a suggestion on PR #5558.
It removes a new use of
lazy_static, and adds some missing documentation.