fix: use [warning] markup for uninstall command output instead of [error]#663
Open
kuishou68 wants to merge 1 commit into
Open
fix: use [warning] markup for uninstall command output instead of [error]#663kuishou68 wants to merge 1 commit into
kuishou68 wants to merge 1 commit into
Conversation
…loses Z4nzu#662) Signed-off-by: Cocoon-Break <54054995+kuishou68@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes inconsistent Rich markup in
core.pywhere uninstall commands were displayed with[error](red) style instead of[warning](yellow), misleading users into thinking something went wrong.Change
core.pyconsole.print(f"[error]→ {cmd}[/error]")console.print(f"[warning]→ {cmd}[/warning]")Why it matters
The
install()method correctly uses[warning](yellow) to display each command before running it — this is just an informational status, not an error.The
uninstall()method used[error](red) for the same pattern, causing uninstall commands to appear as errors in the terminal. This confuses users who think the uninstall is failing when it is actually running normally.Closes #662
Signed-off-by: Cocoon-Break 54054995+kuishou68@users.noreply.github.com