Skip to content

Ps updates - #11

Open
git14 wants to merge 10 commits into
mainfrom
ps-updates
Open

Ps updates#11
git14 wants to merge 10 commits into
mainfrom
ps-updates

Conversation

@git14

@git14 git14 commented Sep 30, 2024

Copy link
Copy Markdown
Collaborator

Minor updates for typos in text and screen shots.

One functional change to parse the signing keys json before sending it to Okta.

@csalas-yubico csalas-yubico left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a few things I need clarity on before I approve - The only item that may require some changes will be the ones made to the /flows/okta.md page

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not following the reason for this change. Is there a reason we're changing this one to a String, but not the correlated field in the action output?

- street_address
- apt_or_unit
- city
- region

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I'm not mistaken, I think these variable names are "auto populated" by the labels that are configured here

So either we need to mention in the previous page to use the "custom" labels denoted below, or revert back so that the naming is consistent

Comment thread docs/static/img/pre-reg/pr-52.png

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the inner comment on the variable names provided by the catalog item

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants