Promote signature failure and cache corruption logs from DEBUG to WARN

Yubico · Sep 15, 2022 · 8cf2b92 · 8cf2b92
1 parent b6a8ee4
commit 8cf2b92
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/NEWS b/NEWS
@@ -44,6 +44,8 @@ Changes:
 
 * The `AuthenticatorToBeFiltered` argument of the `FidoMetadataService` runtime
   filter now omits zero AAGUIDs.
+* Promoted log messages in `FidoMetadataDownloader` about BLOB signature failure
+  and cache corruption from DEBUG level to WARN level.
 
 Fixes:
 

diff --git a/...thn-server-attestation/src/main/java/com/yubico/fido/metadata/FidoMetadataDownloader.java b/...thn-server-attestation/src/main/java/com/yubico/fido/metadata/FidoMetadataDownloader.java
@@ -834,7 +834,7 @@ private Optional<MetadataBLOB> refreshBlobInternal(
       return Optional.of(downloadedBlob);
     } catch (FidoMetadataDownloaderException e) {
       if (e.getReason() == Reason.BAD_SIGNATURE && cached.isPresent()) {
-        log.debug("New BLOB has bad signature - falling back to cached BLOB.");
+        log.warn("New BLOB has bad signature - falling back to cached BLOB.");
         return cached;
       } else {
         throw e;
@@ -954,7 +954,7 @@ private Optional<MetadataBLOB> loadCachedBlobOnly(X509Certificate trustRootCerti
           try {
             return parseAndVerifyBlob(cached, trustRootCertificate);
           } catch (Exception e) {
-            log.debug("Failed to read or parse cached BLOB.", e);
+            log.warn("Failed to read or parse cached BLOB.", e);
             return null;
           }
         });