Use explicit jackson-bom dependencies to control Jackson versions

Yubico · May 2, 2023 · 5a19899 · 5a19899 · github-actions · May 2, 2023
1 parent 57b28e4
commit 5a19899
Show file tree

Hide file tree

Showing 5 changed files with 7 additions and 3 deletions.
diff --git a/NEWS b/NEWS
@@ -2,8 +2,9 @@
 
 Fixes:
 
-* Removed version constraints on non-core Jackson modules; Jackson ships its own
-  BOM constraints to align module versions.
+* Added explicit `dependencyManagement` dependencies on `jackson-bom`, and
+  replaced version constraints on other Jackson modules with version constraint
+  on `jackson-bom`.
 * Fixed incompatibility with Jackson version 2.15.0-rc1 and later.
 * Fixed linking issue when running in Java 8.
 

diff --git a/build.gradle b/build.gradle
@@ -33,7 +33,7 @@ wrapper {
 dependencies {
   constraints {
     api('com.augustcellars.cose:cose-java:[1.0.0,2)')
-    api('com.fasterxml.jackson.core:jackson-databind:[2.13.2.1,3)')
+    api('com.fasterxml.jackson:jackson-bom:[2.13.2.1,3)')
     api('com.google.guava:guava:[24.1.1,32)')
     api('com.upokecenter:cbor:[4.5.1,5)')
     api('org.apache.httpcomponents.client5:httpclient5:[5.0.0,6)')

diff --git a/webauthn-server-attestation/build.gradle.kts b/webauthn-server-attestation/build.gradle.kts
@@ -30,6 +30,7 @@ dependencies {
 
   api(project(":webauthn-server-core"))
 
+  implementation(platform("com.fasterxml.jackson:jackson-bom"))
   implementation(project(":yubico-util"))
   implementation("com.fasterxml.jackson.core:jackson-databind")
   implementation("org.slf4j:slf4j-api")

diff --git a/webauthn-server-core/build.gradle.kts b/webauthn-server-core/build.gradle.kts
@@ -15,6 +15,7 @@ description = "Yubico WebAuthn server core API"
 dependencies {
   api(platform(rootProject))
 
+  implementation(platform("com.fasterxml.jackson:jackson-bom"))
   implementation(project(":yubico-util"))
   implementation("com.augustcellars.cose:cose-java")
   implementation("com.fasterxml.jackson.core:jackson-databind")

diff --git a/yubico-util/build.gradle.kts b/yubico-util/build.gradle.kts
@@ -16,6 +16,7 @@ dependencies {
   api(platform(rootProject))
 
   api("com.fasterxml.jackson.core:jackson-databind")
+  api(platform("com.fasterxml.jackson:jackson-bom"))
 
   implementation("com.fasterxml.jackson.dataformat:jackson-dataformat-cbor")
   implementation("com.fasterxml.jackson.datatype:jackson-datatype-jdk8")
Package	Coverage	Stats	Prev	Prev
Overall	81 % 🔹	1265 🔻 / 1559 🔹	81 %	1267 / 1559
`com.yubico.fido.metadata`	68 % 🔹	217 🔹 / 318 🔹	68 %	217 / 318
`com.yubico.internal.util`	47 % 🔹	57 🔹 / 120 🔹	47 %	57 / 120
`com.yubico.webauthn`	87 % 🔹	558 🔹 / 637 🔹	87 %	558 / 637
`com.yubico.webauthn.attestation`	92 % 🔹	13 🔹 / 14 🔹	92 %	13 / 14
`com.yubico.webauthn.data`	93 % 🔹	395 🔻 / 423 🔹	93 %	397 / 423
`com.yubico.webauthn.extension.appid`	100 % 🏆	13 🔹 / 13 🔹	100 %	13 / 13
`com.yubico.webauthn.extension.uvm`	50 % 🔹	12 🔹 / 24 🔹	50 %	12 / 24
`com.yubico.webauthn.meta`	0 % 🔹	0 🔹 / 10 🔹	0 %	0 / 10