-
Notifications
You must be signed in to change notification settings - Fork 145
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
`webauthn-server-core`: Breaking changes to experimental features: - Added Jackson annotation `@JsonProperty` to method `RegisteredCredential.isBackedUp()`, changing the property name from `backedUp` to `backupState`. `backedUp` is still accepted during deserialization but will no longer be emitted during serialization. New features: - Added method `.isUserVerified()` to `RegistrationResult` and `AssertionResult` as a shortcut for accessing the UV flag in authenticator data. - Updated README and JavaDoc to use the "passkey" term and provide more guidance around passkey use cases. - Added `Automatic-Module-Name` to jar manifest. Fixes: - `AuthenticatorAttestationResponse` now tolerates and ignores properties `"publicKey"` and `"publicKeyAlgorithm"` during JSON deserialization. These properties are emitted by the `PublicKeyCredential.toJSON()` method added in WebAuthn Level 3. - Relaxed Guava dependency version constraint to include major version 32. - `RelyingParty.finishAssertion` now behaves the same if `StartAssertionOptions.allowCredentials` is explicitly set to a present, empty list as when absent. `webauthn-server-attestation`: New features: - Added option `verifyDownloadsOnly(boolean)` to `FidoMetadataDownloader`. When set to `true`, the BLOB signature will not be verified when loading a BLOB from cache or when explicitly given. Default setting is `false`, which preserves the previous behaviour. - Added `Automatic-Module-Name` to jar manifest. Fixes: - Made Jackson setting `PROPAGATE_TRANSIENT_MARKER` unnecessary for JSON serialization with Jackson version 2.15.0-rc1 and later.
- Loading branch information
Showing
53 changed files
with
1,487 additions
and
498 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -39,7 +39,7 @@ jobs: | |
|
||
strategy: | ||
matrix: | ||
java: [17] | ||
java: ["17.0.7"] | ||
distribution: [temurin, zulu, microsoft] | ||
|
||
steps: | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
33 changes: 33 additions & 0 deletions
33
buildSrc/src/main/groovy/project-convention-code-formatting-internal.gradle
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,33 @@ | ||
project.apply(plugin: "com.diffplug.spotless") | ||
project.apply(plugin: "io.github.cosmicsilence.scalafix") | ||
|
||
spotless { | ||
java { | ||
googleJavaFormat() | ||
} | ||
scala { | ||
scalafmt("2.6.3").configFile(project.rootProject.file("scalafmt.conf")) | ||
} | ||
} | ||
|
||
scalafix { | ||
configFile.set(project.rootProject.file("scalafix.conf")) | ||
|
||
// Work around dependency resolution issues in April 2022 | ||
semanticdb.autoConfigure.set(true) | ||
semanticdb.version.set("4.5.5") | ||
} | ||
|
||
project.dependencies.scalafix("com.github.liancheng:organize-imports_2.13:0.6.0") | ||
|
||
|
||
project.afterEvaluate { | ||
// These need to be in afterEvaluate due to this plugin | ||
// being conditionally applied for Java 11+ only | ||
project.tasks.spotlessApply.configure { dependsOn(project.tasks.scalafix) } | ||
project.tasks.spotlessCheck.configure { dependsOn(project.tasks.checkScalafix) } | ||
|
||
// Scalafix adds tasks in afterEvaluate, so their configuration must be deferred | ||
project.tasks.scalafix.finalizedBy(project.tasks.spotlessApply) | ||
project.tasks.checkScalafix.finalizedBy(project.tasks.spotlessCheck) | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
34 changes: 3 additions & 31 deletions
34
buildSrc/src/main/kotlin/project-convention-code-formatting.gradle.kts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,32 +1,4 @@ | ||
plugins { | ||
id("com.diffplug.spotless") | ||
id("io.github.cosmicsilence.scalafix") | ||
} | ||
|
||
spotless { | ||
java { | ||
googleJavaFormat() | ||
} | ||
scala { | ||
scalafmt("2.6.3").configFile(project.rootProject.file("scalafmt.conf")) | ||
} | ||
} | ||
|
||
scalafix { | ||
configFile.set(project.rootProject.file("scalafix.conf")) | ||
|
||
// Work around dependency resolution issues in April 2022 | ||
semanticdb.autoConfigure.set(true) | ||
semanticdb.version.set("4.5.5") | ||
} | ||
|
||
project.dependencies.scalafix("com.github.liancheng:organize-imports_2.13:0.6.0") | ||
|
||
project.tasks.spotlessApply.configure { dependsOn(project.tasks["scalafix"]) } | ||
project.tasks.spotlessCheck.configure { dependsOn(project.tasks["checkScalafix"]) } | ||
|
||
// Scalafix adds tasks in afterEvaluate, so their configuration must be deferred | ||
project.afterEvaluate { | ||
project.tasks["scalafix"].finalizedBy(project.tasks.spotlessApply) | ||
project.tasks["checkScalafix"].finalizedBy(project.tasks.spotlessCheck) | ||
// Spotless dropped Java 8 support in version 2.33.0 | ||
if (JavaVersion.current().isJava11Compatible) { | ||
apply(plugin = "project-convention-code-formatting-internal") | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
345762b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mutation test results
com.yubico.fido.metadata
com.yubico.internal.util
com.yubico.webauthn
com.yubico.webauthn.attestation
com.yubico.webauthn.data
com.yubico.webauthn.extension.appid
com.yubico.webauthn.extension.uvm
com.yubico.webauthn.meta
Previous run: 1576b3d - Diff
Detailed reports: workflow run #233