fix: calibrate UF-F3 PDF severity so must-fix means certain rejection (#82)#83
Open
YuZh98 wants to merge 2 commits into
Open
fix: calibrate UF-F3 PDF severity so must-fix means certain rejection (#82)#83YuZh98 wants to merge 2 commits into
YuZh98 wants to merge 2 commits into
Conversation
Previously every per-page body-size deviation emitted must-fix, which false-failed real submissions the UF Graduate School accepts: a page dominated by a float (a \footnotesize table or \small figure sub-caption) has a modal glyph size below 12pt, but that caption/cell text is not running body text and UF tolerates it. Calibrate so must-fix is reserved for certain rejection: a deviating page is must-fix only when the document-wide modal body size is itself off 12pt (a global override) or the page's body text is larger than 12pt (oversized text is never a tolerated float). An undersized page on an otherwise-12pt document is demoted to review. Closes #82.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Calibrate the UF-F3 PDF-layer severity so must-fix means certain rejection. Previously every per-page body-size deviation emitted must-fix.
A deviating page is now must-fix only when:
\fontsizeoverride), orAn undersized page on an otherwise-12pt document (a
\footnotesizetable or a\smallfigure sub-caption) is demoted to review.Why
The old logic false-failed real dissertations the UF Graduate School accepts. The PDF check derives
body_sizeas the per-page modal glyph size; on a page dominated by a float, that modal is the caption/cell font, not running body text. A confirmed-accepted submission with\footnotesizeappendix tables and\smallsub-captions was flagged with 5 must-fix items. must-fix must mean "the editorial office will reject this"; small caption/table fonts do not. Closes #82.How it works
_document_body_size(pages)returns the document-wide modal body size, ties resolving toward 12pt then the smaller size (an ambiguous document is treated as conforming → its deviating pages route to review)._check_f3emits must-fix whendoc_deviates or oversized, else review.Verification
_document_body_sizeedge cases.\fontsize{20}violation fixture still fires must-fix (oversized branch).0 must-fix, 5 review(was5 must-fix).Docs
docs/uf-rules.mdUF-F3 section documents the severity calibration.CHANGELOG.md[Unreleased] → Changed.