Fix slow Docker container termination #491
Open
+17
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabe565
force-pushed
the
fix-docker-slow-termination
branch
from
f9f8113 to
0647914
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey! This project is a lot of fun, but I've noticed that the Docker containers are slow to terminate. When I stop them, the containers keep running up until Docker decides to kill them. This is due to the shell scripts being run as PID 0, and not passing signals to node.
This PR changes the startup scripts to use
exec, which replaces the script PID with the command it runs. This means when Docker sends aSIGTERM, it will go directly to node, immediately telling it to exit.I also went ahead and added
set -ewhich makes a script exit if a command fails. This removes the need for chaining&&.