refactor: move idle container implementations into internal/idle package - #93
Merged
Merged
Conversation
Move all idle_*.go files into a new internal/idle package, converting the container types to generics to break the import cycle with the root package: - internal/idle now hosts the IdleContainer[T] interface, the IdleContainerType enum, and generic implementations: LinkedList, MinHeap, Slice, RingQueue, Treap - worker implements the new Dated interface (DatedTime()) required by the containers - Pool now holds an idle.IdleContainer[*worker] and constructs containers via the generic constructors - public API preserved: IdleContainerType and the LinkedListType/MinHeapType/etc. constants are re-exported from the root package via type alias Also: - move idle container unit tests into internal/idle with a testWorker helper - move Pool+RingQueue integration tests to pool_ringqueue_test.go - move TestTaskQueueSizeConfiguresHandoffCapacity into pool_test.go and add the GetTaskQueueCapacity() getter to support external-package testing - delete the old idle_*.go files from the root directory
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move all idle_*.go files into a new internal/idle package, converting the container types to generics to break the import cycle with the root package:
Also: