fix: preserve FIFO order in overflow buffer - #103
Merged
Merged
Conversation
Yiming1997
approved these changes
Sep 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Problem
When the handoff channel was full,
PushAndForwardremoved the oldest task before attempting to forward it. If forwarding failed, it appended that task back to the tail of the buffer.This allowed newer tasks to overtake older ones, violating FIFO semantics and potentially delaying old tasks indefinitely during sustained backpressure.
Solution
Peek at the oldest task first, attempt the handoff, and remove it from the buffer only when the handoff succeeds. If it fails, the task remains at the head unchanged.
Validation
go test ./...go test -race -count=1 . -timeout 5mgo vet ./...Scope
No public API changes. No changes to worker scaling, capacity limits, or task execution behavior.