Conversation
…з систему контроля версий
Untitled Pull Request
…3_start # Conflicts: # MovieQuiz/AppDelegate.swift
So1ovyov
reviewed
Feb 21, 2024
| static var ypBackground: UIColor { UIColor(named: "YP Background") ?? UIColor.darkGray } | ||
| static var ypGray: UIColor { UIColor(named: "YP Gray") ?? UIColor.gray } | ||
| static var ypWhite: UIColor { UIColor(named: "YP White") ?? UIColor.white} | ||
| } |
So1ovyov
reviewed
Feb 21, 2024
| // Created by Кирилл Марьясов on 19.02.2024. | ||
| // | ||
|
|
||
| import Foundation |
So1ovyov
reviewed
Feb 21, 2024
| let image: UIImage | ||
| let question: String | ||
| let questionNumber: String | ||
| } |
So1ovyov
reviewed
Feb 21, 2024
|
|
||
| import UIKit | ||
|
|
||
| class AlertPresenter { |
There was a problem hiding this comment.
Давай добавим модификатор final для этого класса. Он необходим для оптимизации и скорости проекта, также не позволит наследоваться от данного класса.
So1ovyov
reviewed
Feb 21, 2024
|
|
||
| final class MovieQuizViewController: UIViewController { | ||
| final class MovieQuizViewController: UIViewController, QuestionFactoryDelegate { | ||
| func didReceiveNextQuestion(question: QuizQuestion?) { |
There was a problem hiding this comment.
Давай структурируем файлы в проекте так, чтобы понятнее было где что располагается. Вот отличный пример
So1ovyov
reviewed
Feb 21, 2024
|
|
||
| import Foundation | ||
|
|
||
| class QuestionFactory: QuestionFactoryProtocol { |
There was a problem hiding this comment.
Проверь во всех классах наличие модификатора final
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.