Conversation
…cion de verbo correcta
controller.js
Outdated
| if (err) { | ||
| res.send(500, "FAKE-SERVER is misconfigured"); | ||
| } | ||
| send(parseInt(200, 10), headers, data); |
There was a problem hiding this comment.
no need to parseInt if you know it is going to be an integer.
|
Thanks for your contribution. A few questions/requests tho:
all other comments are inline. |
|
You're welcome! @bigodines well, when I found your work throught github, I guessed that I could put it in my lan for my coworkers. So, README2.html and a /howTo endpoint, it's just a simple way to explain how it works for'em. Sorry for tabs!!! I forgot to change my editor configuration for js... :O |
- controller.js calls to fakeresponse has changed - fakeresponse.js refactorized match and delOne to be one method. - test/controller.js improvements in test and changes - test/fakeresponse.js improvements in test and changes
|
I did some new changes with last commit. Hope everyhting is right. Regards. |
|
I also have a change to add CORS if you want. |
|
Hi, @bigodines, I'm not sure if you think that I have to improve something. Don't hesitate to tell me. Regards. |
|
unfortunately, I've lost permissions to merge your PR to this project as I don't work for yahoo anymore and have been removed from the github organization :( |
|
:s well, I'll wait for the next master developer. |
|
Thank you for submitting this pull request, however I do not see a valid CLA on file for you. Before we can merge this request please visit https://yahoocla.herokuapp.com/ and agree to the terms. Thanks! 😄 |
|
CLA is valid! |
|
Anyone owns this repo? |
4 participants
Hi!
I've just added some new features.
delOne. Instead of flush, now, you can delete a route one by one.
getAll. Retrieve all routes.
add. Modified to accept 'verb' as part of the route.
I've also added a poor posibility to retrieve the HOWTO as html.
Guess you like it and sorry with commit's mess! It's my first github contribution and my first node.js, too!
Regards.