Skip to content

Conversation

@YaaZ
Copy link
Owner

@YaaZ YaaZ commented Nov 12, 2025

No description provided.

@YaaZ YaaZ linked an issue Nov 12, 2025 that may be closed by this pull request
@YaaZ YaaZ self-assigned this Nov 12, 2025
Copy link

@sharadhr sharadhr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice; On top of the rest of the suggestions, I would add a quick comment that this CMakeLists file needs to be the top-level when used in a package manager.

@YaaZ
Copy link
Owner Author

YaaZ commented Nov 13, 2025

Yes, for distribution it's going to include only include (🤡) directory, with bundled VMA header, see release.yml
So for the final consumer, include/CMakeLists.txt should indeed be the top-level one.
I don't maintain the package manager versions, but I suggest that it should be done in a similar way there too.

@YaaZ
Copy link
Owner Author

YaaZ commented Nov 14, 2025

Okay, 1.4.333 won't work - KhronosGroup/Vulkan-Hpp#2362

@YaaZ
Copy link
Owner Author

YaaZ commented Nov 21, 2025

Finally, all green and I'm going to merge this into master.
Release for v3.3.0 will be created later (hopefully next week), as I am waiting for the breaking change from the upstream: KhronosGroup/Vulkan-Hpp#2349

@YaaZ YaaZ merged commit 4498a3e into master Nov 21, 2025
51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing Support for Vulkan RAII Headers

3 participants