-
Notifications
You must be signed in to change notification settings - Fork 41
V3.3.0 #66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Respect ifdef blocks in .cppm exports - Use VULKAN_HPP_ENABLE_STD_MODULE instead of VMA_ENABLE_STD_MODULE
sharadhr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice; On top of the rest of the suggestions, I would add a quick comment that this CMakeLists file needs to be the top-level when used in a package manager.
|
Yes, for distribution it's going to include only include (🤡) directory, with bundled VMA header, see release.yml |
|
Okay, 1.4.333 won't work - KhronosGroup/Vulkan-Hpp#2362 |
+ Updated README + Enabled weekly builds
|
Finally, all green and I'm going to merge this into master. |
No description provided.