Skip to content

Conversation

@liujinhui-job
Copy link

When two threads concurrently invoke the socket function, the absence of lock protection in citp_fdinfo_init may occasionally result in identical sequence numbers (seq) being assigned to different file descriptor information (fdi) entries.

atomic add seq
@liujinhui-job liujinhui-job requested a review from a team as a code owner June 30, 2025 15:11
Copy link
Contributor

@ol-alexandra ol-alexandra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change itself looks reasonable, but the commit log should include more details, I think. The description of the pull request includes all these details, but the git commit log does not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants