fix(tui): hide sidebar toggle button when sidebar is collapsed#1633
Open
MeGaurav4 wants to merge 1 commit into
Open
fix(tui): hide sidebar toggle button when sidebar is collapsed#1633MeGaurav4 wants to merge 1 commit into
MeGaurav4 wants to merge 1 commit into
Conversation
The toggle button rendered at a fixed 3-column width even when the sidebar was hidden, wasting space on narrow terminals. It is now only rendered while the sidebar is visible, and contentWidth no longer reserves its 4-column footprint when collapsed. Closes XiaomiMiMo#1626
MeGaurav4
force-pushed
the
fix/sidebar-toggle-columns-1626
branch
from
3c785c2 to
b98d2e3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hides the TUI sidebar toggle button when the sidebar is collapsed so it no longer wastes terminal columns on narrow screens.
The toggle button rendered at a fixed 3-column width regardless of sidebar state, and contentWidth reserved a 4-column footprint even when the sidebar was hidden. Now the button is only rendered while the sidebar is visible, and contentWidth reserves space only when the sidebar is shown. Reopening still works via the sidebar.toggle keybind (Ctrl+X B).
Closes #1626
Verification