fix(memory): normalize Windows backslash paths in parsePath and parseCcPath#1573
Open
gorevyoneticisi wants to merge 2 commits into
Open
fix(memory): normalize Windows backslash paths in parsePath and parseCcPath#1573gorevyoneticisi wants to merge 2 commits into
gorevyoneticisi wants to merge 2 commits into
Conversation
…CcPath The memory FTS index is completely broken on Windows because parsePath() and parseCcPath() use forward-slash regexes against backslash-separated paths produced by path.join(). This means memory_fts is always empty on Windows and Memory.search returns zero results. Normalize the input path to forward slashes before regex matching in both functions. This is a no-op on Unix (paths already use /) and fixes the Windows case. Adds 4 Windows-specific tests covering global, project, session, and task scopes with backslash paths. Closes XiaomiMiMo#1571
…tform compat The buildPath tests hardcoded forward-slash paths in expected values, but path.join() on Windows returns backslash-separated paths. Use path.join() in the assertions so tests pass on both Unix and Windows. All 31 memory paths tests now pass on Windows.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The memory FTS index is completely broken on Windows.
parsePath()andparseCcPath()use forward-slash regexes against backslash-separated paths produced bypath.join(), so.mdfiles under the memory directory never match. This meansmemory_ftsis always empty on Windows andMemory.searchreturns zero results.Changes
packages/opencode/src/memory/paths.ts: Normalize input paths to forward slashes before regex matching inparsePath()andparseCcPath(). No-op on Unix (paths already use/), fixes the Windows case.packages/opencode/test/memory/paths.test.ts:buildPathtest failures by usingpath.join()in expected values instead of hardcoded forward slashes.Test Results
All 31 memory paths tests pass on Windows (previously 25 pass, 2 fail on original code).
Evidence
Closes #1571