Conversation
Phase DB classifies vendor sub-type flags (VendorAmmo, VendorReagent, etc.) from vendoritems.json ground truth for SoM and TBC. However, Phase 1 cross-references by Entry ID across all three expansions (SoM, TBC, Wrath), and Wrath has no vendoritems.json — its NpcFlags come from DBC data which may be incorrect. Phase 1 unions all flags and propagates them back, overwriting Phase DB ground truth for SoM/TBC vendors. Before fix (audit mismatches): SoM: -VendorAmmo: 81, -VendorReagent: 121 TBC: -VendorAmmo: 102, -VendorReagent: 235 Fix: Track all vendors present in vendoritems.json in a HashSet regardless of whether Phase DB changed their flags (since "no VendorAmmo" is ground truth too). Phase 1 (ApplyFlags), Phase 2 (ApplyFlagsBySubName), and Phase 3 (ApplyKeywordClassification) now skip these vendors — their flags are already correct from ground truth. Only the application step needs guarding because Phase DB already corrected the NpcFlag values in-memory before Phase 1 runs. The contamination only happens when Phase 1 applies unioned flags back to ground-truth vendors. After fix (audit mismatches): SoM: -VendorAmmo: 0, -VendorReagent: 0 TBC: -VendorAmmo: 0, -VendorReagent: 0 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Xian55
added
bugfix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
vendoritems.jsonvendoritems.jsonin aHashSet<(string, int)>— Phase 1 (ApplyFlags), Phase 2 (ApplyFlagsBySubName), and Phase 3 (ApplyKeywordClassification) now skip these vendorsBefore fix (audit
-mismatches = incorrect flags on ground-truth vendors)After fix
Test plan
dotnet build Utilities/ClassifyVendorFlags— builds successfullydotnet run --project Utilities/ClassifyVendorFlags -- --audit—-VendorAmmoand-VendorReagentcounts drop to zero for SoM/TBC🤖 Generated with Claude Code