Sound prefs tab redesign

[vorot93]

Remember Sound notifications tab in Preferences window? This is how it looks like now:

It works this way:

• On Preferences window launch the setting strings get loaded into memory and applied to widgets
• User types the file location into GtkEntry or selects through GtkFileSelection dialog (on close issues a signal to function that overwrites GtkEntry contents)
• After clicking OK for Preferences a signal is issued to ok_callback that copies strings from GtkEntry to memory.

While it works right now, it poses several design and technical problems that we need to solve sooner or later:

• Text and file selection widgets duplicate each other. You can type the full path in the latter. It's specifically designed for file operations after all.
• Code is clumsy and rotten. It repeats itself over and over and uses deprecated lib stack. For instance, it relies on pre-GLib object system while GtkFileSelection... well, see for yourself.

Hello, 1998!

Needless to say that if we plan to keep up wth GTK+ devs we need to move ASAP. Therefore:

The new and redesigned sound preferences tab

• Fully fresh. Old GTK1 signals replaced with GObject, GtkFileSelection upgraded to GtkFileChooser. Code is compatible with GTK+ 3.
• DRY. 200 lines slimmer.
• As an added bonus, new file_dialog_button (char *file) function for quick addition of generic FileChooserButton.

Why [IN PROGRESS] tag? There are two bugs I have not been able to solve yet.

• Didn't find a way to manually make FileChooser empty on launch. Results in working directory (~) being selected if the sound is unset.

• get_new_defaults() fails to read GtkFileChooser contents on save:
  assertion 'GTK_IS_FILE_CHOOSER (chooser)' failed
  (fails to read GtkFileChooserButton properly)

  Only applies to FileChoosers inside pref_sound_conf_append - scope related?

This is my first major GUI coding attempt. Any feedback and bug fixes are welcome.

[illwieckz]

It’s very good, see #91 ;-)

[illwieckz]

• Didn't find a way to manually make FileChooser empty on launch. Results in working directory (~) being selected if the sound is unset.

Is this a real issue ?

[vorot93]

@illwieckz in practice no, but your terminal will be filled with attempts to play a directory.

[vorot93]

Fixed both issues. It does throw warnings into terminal on save though. Please merge.

[illwieckz]

The configuration window does not show which sounds is configured when you reopen the configuration window (it displays none even if a sound is configured).

[illwieckz]

Also, we can both configure the player and play a sound in the configuration window, but you can't play the sound if you have not yet save the configuration before. I mean, you pick a player binary, you want to prelisten, it says the binary is not found, you must save before.

[Edit, the issue was probably there before, but it could be good to fix it too]

[illwieckz]

but thank you, it's a good work. 😃

[vorot93]

1. Fixed.
2. Outside the scope of this pull request.

[illwieckz]

1. Thanks
2. Yes, it was there before, see must save prefs before prelistening stuff when changing audio player #178

[illwieckz]

Thanks for this good work.

[jmallach]

Thanks for great patches like this one, @skybon!