Repository navigation
2.0.1: check the settings of a restored backup - #36
Merged
Merged
Conversation
A restored backup put its settings in the process environment without the checks applied in the app, so it could point the printer device at any file the service can write to, such as the update guard script in /opt/printr. The restore now fails on an invalid setting, and saved settings are checked again at startup.
Wi-Fi setup, backup and restore, settings in the app, signed automatic updates, printer discovery and ANTHROPIC_BASE_URL: where they take input, which routes work without an account, and how issues in them are rated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Settings in a restored backup now go through the same checks as in the app. Also updates the OSS Scanner threat model for 2.0.