adapt to new channel occupancy on aqmon #1576
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
…m:XENONnT/straxen into aqmon_adjustment_for_busy_firmware_change
|
The issue seems to be DB access for creation of a context. This context is not used for the files I changed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the code in this PR do / what does it improve?
It puts the correct labels on the veto and trigger start and stop hits. The labels are not static anymore since the recent Caen V1495 firmware upgrade.
When e.g. on channel 802 there was always the "high energy veto (HEV) stop" signal, now it can be one of the following: HEV, HEV_tag, Neutron-Generator-Anti-Veto or Fractional Lifetime Veto stop signal.
Now the channels are still named after their primary usage, but the occupancy in a run is used for the naming of the interval.
Can you briefly describe how it works?
The class used gets the run-doc, finds what parameters the V1495 was run with, and labels the intervals accordingly.
Can you give a minimal working example (or illustrate with a figure)?
The usage does not change. You just load the data with the plugin, as you did before. There are just more "veto"-types now. Backwards compatibility is ensured and also automatic. If it doesn't find the new configs it knows that the V1495 was run with the old firmware.
In cutax, there is a branch with the same name, that adapts further processing to be compatible with the changes in this PR.
Please include the following if applicable: